fix: Public link with multiple mounts - #63241
Merged
Merged
Conversation
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
SystemKeeper
changed the title
SystemKeeper
added
bug
3. to review
SystemKeeper
force-pushed
the
fix/noid/public-link-with-multiple-mounts
branch
from
August 14, 2026 10:58
f31eefb to
4c9ecf6
Compare
SystemKeeper
marked this pull request as ready for review
August 14, 2026 10:58
SystemKeeper
requested review from
Altahrim,
icewind1991,
leftybournes and
provokateurin
and removed request for
a team
August 14, 2026 10:58
icewind1991
approved these changes
Aug 14, 2026
Contributor
Author
|
/backport to stable34 |
Contributor
Author
|
/backport to stable33 |
Contributor
Author
|
/backport to stable32 |
7 tasks
Open
susnux
approved these changes
Aug 18, 2026
susnux
left a comment
susnux
left a comment
Contributor
There was a problem hiding this comment.
makes sense - code reviewed but not tested!
This was referenced Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When multiple mounts with different permissions are available to access a file, a public link for such a file might access the wrong (non-shareable) node and show a 404 instead of the file.
Question generally would be if it makes sense to extract that code (e.g.
getFirstShareableNodeByIdor a separate class to resolve these types of nodes).The test was created with help of AI, which pointed out that a similar exists at
server/apps/files_sharing/lib/Listener/RestrictInteractionListener.php
Lines 54 to 56 in 4fcbb98
getNodePermissionsthere. This seems 34+ only, the fix here is also < 34.Checklist
3. to review, feature component)stable32)AI (if applicable)